Update to latest version 2023-10-31 #45151
Conversation
Vidyashreebn
requested review from
johngallardo,
abhinav-ghai,
Aashish93-stack and
sjiherzig
as code owners
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
...-core/src/test/resources/session-records/ComponentsAsyncTests.componentLifecycleTest[1].json
Outdated
Show resolved
Hide resolved
Vidyashreebn
deleted the
dev/digitaltwins/vidyashreeb/update-to-2023-10-31
branch
| @Get("/jobs/imports") | ||
| @ExpectedResponses({ 200 }) | ||
| @UnexpectedResponseExceptionType(ErrorResponseException.class) | ||
| Mono<Response<ImportJobCollection>> list(@HostParam("$host") String host, |
There was a problem hiding this comment.
These are new APIs that are not added to the public client. With the new service version, these new APIs should be exposed in DigitalTwinsClient and DigitalTwinsAsyncClient.
There was a problem hiding this comment.
I don't think so. These are autogenerated and moreover none from DigitalTwinImpl.java are exposed in DigitalTwinsClient and DigitalTwinsAsyncClient
| String nextLinkToUse; | ||
| try (JsonReader jsonReader = JsonProviders.createReader(nextLink)) { | ||
| Object untyped = jsonReader.readUntyped(); | ||
|
|
||
| if (untyped instanceof List || untyped instanceof Map || untyped instanceof String) { | ||
| nextLinkToUse = nextLink; | ||
| } else { | ||
| nextLinkToUse = serializeNextLink(nextLink); | ||
| } | ||
| } catch (IOException ex) { | ||
| nextLinkToUse = serializeNextLink(nextLink); | ||
| } | ||
|
|
||
| QuerySpecification querySpecification = new QuerySpecification().setContinuationToken(nextLinkToUse); |
There was a problem hiding this comment.
Why was the nextLink changed? Is this backward compatible?
There was a problem hiding this comment.
@alzimmermsft has more context on this.
There was a problem hiding this comment.
@srnagar, yes, this change was needed to maintain a piece of backwards compatibility after Digital Twins was migrated to azure-json.
Effectively, a lot of the original Digital Twins SDK was developed with "anything" can be passed so there are a lot of checks to validate and appropriately handle customer inputs. This is just a check for that on the continuation token.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines